Remove useless SpecifyShape #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 170 170
Lines 46923 46939 +16
Branches 11497 11507 +10
=======================================
+ Hits 38009 38025 +16
Misses 6704 6704
Partials 2210 2210
|
jessegrabowski
approved these changes
Jul 6, 2024
| assert ret is None | ||
|
|
||
| # SpecifyShape is needed to raise mismatch between static and specified dim | ||
| out = ss(x, None, 5, 4) |
There was a problem hiding this comment.
Beyond the scope of this PR, but SpecifyShape could just eagerly raise in this case?
There was a problem hiding this comment.
Yes, there's also a config flag to raise during rewrites when shapes are found to be incompatible in the shape feature. But I don't see why not do it all the time.
Can you open an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With improvements in some Op static shape, I see an increase in redundant SpecifyShape that were introduced earlier on, but become irrelevant after more clever Ops were introduced or recreated.
This PR removes useless SpecifyShape when all the specified dims are already encoded in the static shape of the input.
Related Issue
Checklist
Type of change