Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpecifyShape should eagerly raise an error when static shapes disagree #892

Open
jessegrabowski opened this issue Jul 6, 2024 · 0 comments

Comments

@jessegrabowski
Copy link
Member

Description

This came up in #885. The following graph will raise at compile time, but not during graph construction:

x = tensor("x", shape=(None, 5, 3))

# We avoid the helper specify_shape that optimizes some (but not all) cases eagerly
ss = SpecifyShape()
out = ss(x, None, 5, 4)

This should just raise immediately, since x has a static shape 3 on the 3rd dimension, and we're trying to specify a shape of 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant