-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
class attrs should not emit assigning-non-slot msg #7987
Conversation
Pull Request Test Coverage Report for Build 3787058444
π - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add INFERENCE
confidence while we're here.
Also, could you add the example from the issue just to be sure?
Rest LGTM!
204b54b
to
8152b58
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7987 +/- ##
==========================================
- Coverage 95.48% 95.41% -0.08%
==========================================
Files 176 176
Lines 18511 18516 +5
==========================================
- Hits 17676 17667 -9
- Misses 835 849 +14
|
I think we need an actual rebase on main to see the real codecov result @DanielNoord |
Yeah, sadly. Oh well, that's a small price to pay. Sorry for the churn @clavedeluna, you'll need to rebase to get CI to pass π |
This comment has been minimized.
This comment has been minimized.
8152b58
to
b7741eb
Compare
This comment has been minimized.
This comment has been minimized.
Is the test failure genuine? |
I swear the latest pypy 3.8 release is nothing but trouble :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits π
b7741eb
to
d316609
Compare
π€ Effect of this PR on checked open source code: π€ Effect on sentry:
This comment was generated for commit d316609 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-7987-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1baa10e250406d740d0c83f2902e949d84c1ecd8
# Push it to GitHub
git push --set-upstream origin backport-7987-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x Then, create a pull request where the |
@clavedeluna Do you want to try this back port yourself? |
Type of Changes
Description
Pylint was raising
assigning-non-slot
when a class attribute was re-assigned, which I believe is incorrect given that__slots__
is meant for instance attrs.Closes #6001