Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create TERMINATING_FUNCS_QNAMES #7825

Merged
merged 1 commit into from
Nov 22, 2022
Merged

create TERMINATING_FUNCS_QNAMES #7825

merged 1 commit into from
Nov 22, 2022

Conversation

clavedeluna
Copy link
Collaborator

Type of Changes

Type
✓ ✨ New feature

Description

Making this set a global frozenset will have a marginal perf gain.

Closes #7817

@coveralls
Copy link

coveralls commented Nov 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3526799978

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.428%
Totals Coverage Status
Change from base Build 3524990717: 0.0%
Covered Lines: 17471
Relevant Lines: 18308
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Nov 22, 2022
Pierre-Sassoulas
Pierre-Sassoulas requested changes Nov 22, 2022
View reviewed changes
doc/whatsnew/fragments/7817.internal Outdated
@@ -0,0 +1,3 @@
Create ``TERMINATING_FUNCS_QNAMES`` frozenset for improved performance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should document this

@Pierre-Sassoulas Pierre-Sassoulas added the Skip news 🔇 This change does not require a changelog entry label Nov 22, 2022
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) November 22, 2022 20:20
@Pierre-Sassoulas Pierre-Sassoulas merged commit 0a6b182 into pylint-dev:main Nov 22, 2022
clavedeluna added a commit to clavedeluna/pylint that referenced this pull request Jan 2, 2023
@clavedeluna
Create TERMINATING_FUNCS_QNAMES (pylint-dev#7825)
c6fcb0f
Pierre-Sassoulas added a commit that referenced this pull request Jan 2, 2023
@clavedeluna @Pierre-Sassoulas
Backport (#7987) (#8005)
1673aa6 
* class attrs should not emit assigning-non-slot msg (#7987)

* Create `TERMINATING_FUNCS_QNAMES` (#7825)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make qnames a global frozenset in is_terminating_func
3 participants
@clavedeluna @coveralls @Pierre-Sassoulas