Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an exception at install for python < 3.6.2 #5171

Merged
merged 5 commits into from
Oct 17, 2021
Merged

Add an exception at install for python < 3.6.2 #5171

merged 5 commits into from
Oct 17, 2021

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✓ 🐛 Bug fix
✓ 📜 Docs

See #5065 for reasoning

@Pierre-Sassoulas Pierre-Sassoulas added Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow labels Oct 17, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.0 milestone Oct 17, 2021
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the add-warning-for-3.6.0or3.6.1 branch from 206c437 to b2cb35b Compare October 17, 2021 09:06
@coveralls
Copy link

coveralls commented Oct 17, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1351119598

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.249%
Totals Coverage Status
Change from base Build 1351096120: 0.0%
Covered Lines: 13632
Relevant Lines: 14619
💛 - Coveralls

cdce8p
cdce8p reviewed Oct 17, 2021
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas @cdce8p
Apply suggestions from code review
25272fd 
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
cdce8p
cdce8p reviewed Oct 17, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas force-pushed the add-warning-for-3.6.0or3.6.1 branch from 414fbc5 to c5ce8dc Compare October 17, 2021 09:33
@Pierre-Sassoulas
Copy link
Member Author

Let's not polish this too much, we'll remove it for 2.12.1 :)

cdce8p
cdce8p reviewed Oct 17, 2021
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not polish this too much, we'll remove it for 2.12.1 :)

😄

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas @cdce8p
Apply suggestions from code review
384b93a 
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Oct 17, 2021
Closed
@Pierre-Sassoulas Pierre-Sassoulas merged commit 37e330c into main Oct 17, 2021
@Pierre-Sassoulas Pierre-Sassoulas deleted the add-warning-for-3.6.0or3.6.1 branch October 17, 2021 09:54
Pierre-Sassoulas added a commit to Pierre-Sassoulas/pylint that referenced this pull request Oct 17, 2021
@Pierre-Sassoulas
Revert "Add an exception at install for python < 3.6.2 (pylint-dev#5171…
0563861 
…)"

This reverts commit 37e330c.
@DanielNoord DanielNoord mentioned this pull request Nov 3, 2021
Closed
5 tasks
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Nov 3, 2021
Closed
9 tasks
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Nov 13, 2021
Merged
Pierre-Sassoulas added a commit that referenced this pull request Nov 13, 2021
@Pierre-Sassoulas
Add a whatsnew entry for python <3.6.2 incompatibility (#5297)
3c6f5cf 
Relates to #5250, #5171
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Nov 15, 2021
Merged
6 tasks
Pierre-Sassoulas added a commit that referenced this pull request Nov 25, 2021
@cdce8p @Pierre-Sassoulas
Require Python 3.6.2 (#5068)
a9c1017 
* Bump python_requires to >= 3.6.2

* Import typing names directly
* Use typing.NamedTuple for MessageTest
* Add default value to MessageStyle

* Revert "Add an exception at install for python < 3.6.2 (#5171)"

This reverts commit 37e330c.

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p approved these changes

Assignees
No one assigned
Labels
Documentation 📗 Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Pierre-Sassoulas @coveralls @cdce8p