Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Python 3.6.2 #5068

Merged
merged 10 commits into from
Nov 25, 2021
Merged

Require Python 3.6.2 #5068

merged 10 commits into from
Nov 25, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 23, 2021

Type of Changes

Type
✓ 🔨 Refactoring
✓ 📜 Docs

Description

For the rational behind this change -> #5065

Closes #5065

@cdce8p cdce8p added Blocked 🚧 Blocked by a particular issue Maintenance Discussion or action around maintaining pylint or the dev workflow labels Sep 23, 2021
@cdce8p cdce8p added this to the 2.12.0 milestone Sep 23, 2021
@coveralls
Copy link

coveralls commented Sep 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1504208974

  • 13 of 13 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 93.506%
Totals Coverage Status
Change from base Build 1504096401: 0.006%
Covered Lines: 13995
Relevant Lines: 14967
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cdce8p, great cleanup !

@pkolbus pkolbus mentioned this pull request Sep 23, 2021
Closed
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Sep 23, 2021
Merged
@DanielNoord DanielNoord removed the Blocked 🚧 Blocked by a particular issue label Sep 24, 2021
@cdce8p cdce8p added the Blocked 🚧 Blocked by a particular issue label Sep 24, 2021
@cdce8p cdce8p force-pushed the feature_python-3.6.2 branch from 2ebbff9 to dcb0423 Compare September 24, 2021 12:55
@cdce8p cdce8p modified the milestones: 2.13.0, 2.12.1 Oct 6, 2021
@cdce8p cdce8p force-pushed the feature_python-3.6.2 branch from dcb0423 to cb88ace Compare October 7, 2021 18:30
@cdce8p
Copy link
Member Author

cdce8p commented Oct 7, 2021

Before merging, check that no new instances of Counter, NoReturn, ... have been added during refactoring!

@cdce8p cdce8p force-pushed the feature_python-3.6.2 branch from cb88ace to 0a3f447 Compare October 7, 2021 18:37
@Pierre-Sassoulas
Copy link
Member

I've rebased on the latest main and reverted the exception on install but it seems I can't push on this branch. Could you allow edit by maintainers ? :)

@cdce8p
Copy link
Member Author

cdce8p commented Oct 17, 2021

I've rebased on the latest main and reverted the exception on install but it seems I can't push on this branch. Could you allow edit by maintainers ? :)

Edits are allowed. I don't disable them usually.

@Pierre-Sassoulas
Copy link
Member

My bad, I took https for the remote branch.

@DanielNoord DanielNoord mentioned this pull request Nov 3, 2021
Closed
5 tasks
This was referenced Nov 21, 2021
Merged
Merged
@Pierre-Sassoulas Pierre-Sassoulas marked this pull request as ready for review November 25, 2021 14:36
@Pierre-Sassoulas Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Nov 25, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit a9c1017 into pylint-dev:main Nov 25, 2021
@cdce8p cdce8p deleted the feature_python-3.6.2 branch November 27, 2021 15:16
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord Awaiting requested review from DanielNoord

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.12.1
Development

Successfully merging this pull request may close these issues.

Start requiring Python 3.6.2 or newer
4 participants
@cdce8p @coveralls @Pierre-Sassoulas @DanielNoord