Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support built-in image overrides - part 1 #462

Merged
merged 3 commits into from
May 31, 2023
Merged

Better support built-in image overrides - part 1 #462

merged 3 commits into from
May 31, 2023

Conversation

tobybellwood
Copy link
Collaborator

This is the first step towards #458

This PR:

  • loosens the test routines checking for exact image names
  • Reorders the DockerPull regex to identify the image reference given
  • Support a case insensitive header check (newer haproxy/http2 headers are all lowercase now)

The actual logic to support the image overrides will be done elsewhere (and likely not by me 😛)

@fubarhouse fubarhouse merged commit 523d432 into main May 31, 2023
@tobybellwood tobybellwood mentioned this pull request Feb 20, 2024
Merged
@tobybellwood tobybellwood mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubarhouse fubarhouse fubarhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobybellwood @fubarhouse