Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to override default service images in .pygmy.yml #458

Closed
tobybellwood opened this issue May 29, 2023 · 8 comments
Closed

Allow users to override default service images in .pygmy.yml #458

tobybellwood opened this issue May 29, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@tobybellwood
Copy link
Collaborator

To allow local customisation, and facilitate easier testing, you should be able to define the image for a built-in service in the .pygmy.yml file (as you can for external services).

This would allow easier testing in the image repos etc

e.g.

services:
  amazeeio-haproxy:
    image: ghcr.io/pygmystack/haproxy:pr-12
  amazeeio-ssh-agent:
    image: ghcr.io/pygmystack/ssh-agent:pr-2
  amazeeio-dnsmasq:
    image: ghcr.io/pygmystack/dnsmasq:pr-2
  amazeeio-mailhog:
    image: ghcr.io/pygmystack/mailhog:pr-3
@tobybellwood tobybellwood added the enhancement New feature or request label May 29, 2023
@tobybellwood
Copy link
Collaborator Author

Additionally, it doesn't appear that pygmy can easily handle pulling images that aren't present locally (same result without ghcr.io prefix)?

Screenshot from 2023-05-30 11-48-36

@tobybellwood
Copy link
Collaborator Author

Additionally, it doesn't appear that pygmy can easily handle pulling images that aren't present locally (same result without ghcr.io prefix)?

Turns out this was an issue with some greedy regex in the DockerPull routine - i've fixed it in a test branch, but will PR.

@fubarhouse
Copy link
Collaborator

I've now got a working version of this, though I'm not completely happy with the implementation.

I'll clean it up soon and open a PR. 👍

@tobybellwood
Copy link
Collaborator Author

Ooh nice! I'll take a look when you're done and we can get test suites into the images too!

@fubarhouse
Copy link
Collaborator

#469 Resolves this one if you want to give it a test 😄

@tobybellwood
Copy link
Collaborator Author

Looks good, but haven't tested myself - only comment is that I'd use the :main images instead of the pr- ones

@fubarhouse
Copy link
Collaborator

Happy to merge #469?

@fubarhouse
Copy link
Collaborator

Still interested in this one @tobybellwood?
I'm good to merge on your approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants