-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to override default service images in .pygmy.yml #458
Comments
Turns out this was an issue with some greedy regex in the DockerPull routine - i've fixed it in a test branch, but will PR. |
I've now got a working version of this, though I'm not completely happy with the implementation. I'll clean it up soon and open a PR. 👍 |
Ooh nice! I'll take a look when you're done and we can get test suites into the images too! |
#469 Resolves this one if you want to give it a test 😄 |
Looks good, but haven't tested myself - only comment is that I'd use the :main images instead of the pr- ones |
Happy to merge #469? |
Still interested in this one @tobybellwood? |
To allow local customisation, and facilitate easier testing, you should be able to define the image for a built-in service in the .pygmy.yml file (as you can for external services).
This would allow easier testing in the image repos etc
e.g.
The text was updated successfully, but these errors were encountered: