Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter_per_worker flag to data loaders #4873

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Jun 27, 2022

If wished, PyG data loaders can now execute the filtering of data according to samples in the worker process. This eases integration with out-of-memory feature stores.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #4873 (128bba7) into master (927346e) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master    #4873      +/-   ##
==========================================
- Coverage   82.77%   82.76%   -0.02%     
==========================================
  Files         329      329              
  Lines       17679    17703      +24     
==========================================
+ Hits        14634    14652      +18     
- Misses       3045     3051       +6     
Impacted Files Coverage Δ
torch_geometric/loader/hgt_loader.py 90.56% <81.81%> (-2.77%) ⬇️
torch_geometric/loader/link_neighbor_loader.py 92.08% <81.81%> (-1.05%) ⬇️
torch_geometric/loader/neighbor_loader.py 86.12% <81.81%> (-0.54%) ⬇️
torch_geometric/loader/base.py 78.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927346e...128bba7. Read the comment docs.

Copy link
Contributor

@mananshah99 mananshah99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@rusty1s rusty1s merged commit 0f7e018 into master Jun 28, 2022
@rusty1s rusty1s deleted the filter_per_worker branch June 28, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants