Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip-ci] Add alignment benchmarks #7738

Merged
merged 3 commits into from
Apr 7, 2023
Merged

[skip-ci] Add alignment benchmarks #7738

merged 3 commits into from
Apr 7, 2023

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Apr 7, 2023

xref #4648

@dcherian dcherian added the run-benchmark Run the ASV benchmark workflow label Apr 7, 2023
@dcherian dcherian requested a review from Illviljan April 7, 2023 03:52
headtr1ck
headtr1ck approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an important benchmark, thanks!

Maybe we could add an example that requires insertion of nans in-between data. But maybe missing values at the start does the same (I actually don't know), in this case ignore this comment.

Illviljan
Illviljan approved these changes Apr 7, 2023
View reviewed changes
asv_bench/benchmarks/alignment.py Outdated Show resolved Hide resolved
asv_bench/benchmarks/alignment.py Outdated Show resolved Hide resolved
asv_bench/benchmarks/alignment.py Outdated Show resolved Hide resolved
@dcherian @Illviljan
Apply suggestions from code review
826a182 
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
@dcherian dcherian merged commit 8e899ad into pydata:main Apr 7, 2023
@dcherian dcherian deleted the align-bench branch April 7, 2023 22:31
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 18, 2023
@dcherian
$Merge branch 'main' into grouper-objects
5a0ba46 
* main: (34 commits)
  Update whats-new.rst
  Fix binning by unsorted array (pydata#7762)
  Bump codecov/codecov-action from 3.1.1 to 3.1.2 (pydata#7760)
  Fix typing errors using mypy 1.2 (pydata#7752)
  [skip-ci] dev whats-new
  Add whats-new for v2023.04.0 (pydata#7757)
  remove the `black` hook (pydata#7756)
  reword the what's new entry for the `pandas` 2.0 dtype changes (pydata#7755)
  restructure the contributing guide (pydata#7681)
  Continue to use nanosecond-precision Timestamps in precision-sensitive areas (pydata#7731)
  minor doc updates to clarify extensions using accessors (pydata#7751)
  align: Avoid reindexing when join="exact" (pydata#7736)
  `pandas=2.0` support (pydata#7724)
  Clarify vectorized indexing documentation (pydata#7747)
  Avoid recasting a CFTimeIndex (pydata#7735)
  fix typo (pydata#7746)
  [pre-commit.ci] pre-commit autoupdate (pydata#7745)
  Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5 (pydata#7743)
  preserve boolean dtype in encoding (pydata#7720)
  [skip-ci] Add alignment benchmarks (pydata#7738)
  ...
@dcherian dcherian mentioned this pull request May 2, 2023
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Illviljan Illviljan Illviljan approved these changes

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
run-benchmark Run the ASV benchmark workflow topic-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcherian @Illviljan @headtr1ck