Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align: Avoid reindexing when join="exact" #7736

Merged
merged 5 commits into from
Apr 12, 2023
Merged

align: Avoid reindexing when join="exact" #7736

merged 5 commits into from
Apr 12, 2023

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Apr 7, 2023 •
edited
Loading

xref #7730, #7737

@dcherian dcherian requested a review from benbovy April 7, 2023 02:46
@dcherian dcherian added the run-benchmark Run the ASV benchmark workflow label Apr 7, 2023
headtr1ck
headtr1ck approved these changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

733±5μs -> 124±0.7μs 0.17
79.1±0.5ms -> 502±4μs 0.01
71.1±0.5ms -> 124±1μs 0.00

Seems like a good improvement :)

benbovy
benbovy reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@benbovy benbovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dcherian, that's a nice improvement!

One minor comment below (also worth an update in what's new and/or a benchmark?).

xarray/core/alignment.py Outdated Show resolved Hide resolved
@dcherian dcherian merged commit 67ff171 into pydata:main Apr 12, 2023
@dcherian dcherian deleted the optimize-join-exact branch April 12, 2023 14:41
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 18, 2023
@dcherian
$Merge branch 'main' into grouper-objects
5a0ba46 
* main: (34 commits)
  Update whats-new.rst
  Fix binning by unsorted array (pydata#7762)
  Bump codecov/codecov-action from 3.1.1 to 3.1.2 (pydata#7760)
  Fix typing errors using mypy 1.2 (pydata#7752)
  [skip-ci] dev whats-new
  Add whats-new for v2023.04.0 (pydata#7757)
  remove the `black` hook (pydata#7756)
  reword the what's new entry for the `pandas` 2.0 dtype changes (pydata#7755)
  restructure the contributing guide (pydata#7681)
  Continue to use nanosecond-precision Timestamps in precision-sensitive areas (pydata#7731)
  minor doc updates to clarify extensions using accessors (pydata#7751)
  align: Avoid reindexing when join="exact" (pydata#7736)
  `pandas=2.0` support (pydata#7724)
  Clarify vectorized indexing documentation (pydata#7747)
  Avoid recasting a CFTimeIndex (pydata#7735)
  fix typo (pydata#7746)
  [pre-commit.ci] pre-commit autoupdate (pydata#7745)
  Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5 (pydata#7743)
  preserve boolean dtype in encoding (pydata#7720)
  [skip-ci] Add alignment benchmarks (pydata#7738)
  ...
@benbovy benbovy mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbovy benbovy benbovy left review comments

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments regression run-benchmark Run the ASV benchmark workflow topic-cftime topic-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcherian @benbovy @headtr1ck