MAINT: use fontawesome css variables instead of font names #1219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1195
Everything is in the title:
instead of relying on the name of the fonts embeded in fontawesome (which forces us to change them all if we change fa version, we now rely on the css variables injected by fontawesome distribution.
is equivalent to:
I didn't changed the icon content with the SASS mixin. We would loose our capacity to reuse the icon elswhere as the variables needs to be scss compiled one. To be fair unicodes never change so I would say it's ok.