New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use SASS mixin for all our CSS icons #1195

Closed

12rambau opened this issue Feb 17, 2023 · 0 comments · Fixed by #1219

Labels

tag: CSS

Collaborator

12rambau commented Feb 17, 2023

this will work just fine but I think for the sake of robustness we could move one step further (in another PR) and use the CSS variable: https://fontawesome.com/docs/web/add-icons/pseudo-elements#_2-reference-individual-icons. My guess is that upgrading to other versions will be more straight forward (this is running since fa 4)

Originally posted by @12rambau in #1194 (review)

trallard added the tag: CSS label

12rambau mentioned this issue

MAINT: use fontawesome css variables instead of font names #1219

Merged

drammock closed this as completed in #1219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment