Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct path for documentation logo #1131

Closed
wants to merge 1 commit into from
Closed

Conversation

12rambau
Copy link
Collaborator

FIx #1130

@12rambau 12rambau marked this pull request as ready for review January 23, 2023 15:30
@choldgraf
Copy link
Collaborator

hmm why would this suddenly break? This feels somehow related in an unintended way to:

so we should make sure this isn't breaking other people's sites as well...

@rossbar
Copy link
Contributor

rossbar commented Jan 23, 2023

FWIW just checked this locally building the numpydoc docs and it fixed the problem we were seeing.

@choldgraf
Copy link
Collaborator

But html_logo should still work, if it doesn't work anymore then I think we have a bug

@drammock
Copy link
Collaborator

@12rambau OK to close this one in favor of #1132 ?

@12rambau 12rambau closed this Jan 25, 2023
@12rambau 12rambau deleted the 12rambau-patch-1 branch January 25, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logo is not display in the "latest" version of the doc
4 participants