logo is not display in the "latest" version of the doc

[12rambau]

I think we were too fast reviewing #1097.
logo_url seems to be relativ to the _static folder so the name set-up in the docs is leading to _static/_static/logo.svg that of course does not exist.

demo: https://pydata-sphinx-theme.readthedocs.io/en/latest/

[rossbar]

We're seeing this in numpydoc's CI: https://github.com/numpy/numpydoc/actions/runs/3859437463/jobs/6689897153

[12rambau]

@rossbar this one is related to #1097 it should be solved with 0.13

[rossbar]

FWIW I see this with pydata-sphinx-theme==0.11 as well on Sphinx 6.1. I think the bad interaction is with Sphinx 6. v0.12 of the theme works fine for me locally on Sphinx 5.3

[12rambau]

yes that's exactly what it is, they deprecated a jinja internal variable (logo) in favor of (logo_url)

[choldgraf]

I added this to the milestone for the next release because I suspect we will need to do some special casing for sphinx versions to prevent this from breaking for others.

[12rambau]

I'll check favicon as well, I suspect it will need some special casing as well

[12rambau]

from sphinx documentation:

html_logo
If given, this must be the name of an image file (path relative to the configuration directory) that is the logo of the docs, or URL that points an image file for the logo.

html_favicon
If given, this must be the name of an image file (path relative to the configuration directory) that is the favicon of the docs, or URL that points an image file for the favicon.

So it should work with these 2 configurations whatever the sphinx version:

html_logo = "_static/logo.svg"
html_favicon = "_static/logo.svg"

or

html_logo = "https://raw.githubusercontent.com/pydata/pydata-sphinx-theme/main/docs/_static/logo.svg"
html_favicon = "https://raw.githubusercontent.com/pydata/pydata-sphinx-theme/main/docs/_static/logo.svg"

[choldgraf]

Ah ok cool - as long as it works then that sounds great 🙂

[choldgraf]

Ah ok cool - as long as it works then that sounds great 🙂

[choldgraf]

• closed by Standardize logo image behavior between Sphinx and this theme #1132