Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SciPyDifferentialEvolution optimiser #132

Merged

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Dec 6, 2023

This PR adds:

  • SciPyDifferentialEvolution optimiser
  • Adds maxiter as argument to BaseOptimiser with functionality added to NLoptOptimize and SciPyMinimize
  • Adds the required tests for coverage

@BradyPlanden BradyPlanden linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f08d706) 92.59% compared to head (097bc51) 93.03%.
Report is 3 commits behind head on develop.

❗ Current head 097bc51 differs from pull request most recent head 707f16a. Consider uploading reports for the commit 707f16a to get more accurate results

Files Patch % Lines
pybop/optimisers/scipy_optimisers.py 96.15% 2 Missing ⚠️
pybop/_problem.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
+ Coverage    92.59%   93.03%   +0.44%     
===========================================
  Files           33       34       +1     
  Lines         1121     1178      +57     
===========================================
+ Hits          1038     1096      +58     
+ Misses          83       82       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolaCourtier
Copy link
Member

Hi @BradyPlanden, I added logging of the SciPy iterations to bring this branch up to speed with develop - this is the cause of the conflicts.

Copy link
Member

@NicolaCourtier NicolaCourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @BradyPlanden! Just one comment on the changelog and then all good to merge, thanks!

@BradyPlanden BradyPlanden merged commit 6a96156 into develop Dec 8, 2023
@BradyPlanden BradyPlanden deleted the 131-add-scipys-differentialevolution-optimiser branch December 8, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SciPy's DifferentialEvolution Optimiser
2 participants