Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend non-Pints optimisers for plotting #134

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

NicolaCourtier
Copy link
Member

  • Add logging for non-Pints optimisers
  • Add a SciPy minimize example

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7292125) 92.24% compared to head (d88f131) 92.93%.
Report is 17 commits behind head on develop.

Files Patch % Lines
pybop/optimisers/scipy_minimize.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #134      +/-   ##
===========================================
+ Coverage    92.24%   92.93%   +0.69%     
===========================================
  Files           30       34       +4     
  Lines         1031     1146     +115     
===========================================
+ Hits           951     1065     +114     
- Misses          80       81       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @NicolaCourtier! One area that we might want to consider modifying for the future, otherwise LGTM

@NicolaCourtier NicolaCourtier merged commit 6aaa44b into develop Dec 7, 2023
@NicolaCourtier NicolaCourtier deleted the 114-pybop-plotting branch December 7, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants