Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 765 compute grad fem #767

Merged
merged 12 commits into from
Dec 28, 2019
Merged

Issue 765 compute grad fem #767

merged 12 commits into from
Dec 28, 2019

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Dec 20, 2019

Description

Added the gradient operation in the finite element method. This has then been used to compute the ohmic heating in the current collector

Fixes #765

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #767 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   98.36%   98.38%   +0.01%     
==========================================
  Files         179      179              
  Lines        9871     9894      +23     
==========================================
+ Hits         9710     9734      +24     
+ Misses        161      160       -1
Impacted Files Coverage Δ
pybamm/spatial_methods/spatial_method.py 95.12% <ø> (ø) ⬆️
...rmal/xyz_lumped/xyz_lumped_2D_current_collector.py 100% <ø> (ø) ⬆️
...thermal/x_lumped/x_lumped_2D_current_collectors.py 100% <ø> (ø) ⬆️
pybamm/expression_tree/unary_operators.py 96.18% <ø> (ø) ⬆️
pybamm/spatial_methods/scikit_finite_element.py 98.23% <100%> (+0.27%) ⬆️
pybamm/expression_tree/symbol.py 98.29% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b27183...dc2543f. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

eqn = pybamm.grad_squared(var)
eqn_disc = disc.process_symbol(eqn)
ans = eqn_disc.evaluate(None, 3 * y ** 2)
self.assertTrue(all(ans > 0))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np.testing.assert_array_less(0, ans) would give more informative failure messages

@rtimms rtimms merged commit 3098ec6 into master Dec 28, 2019
@rtimms rtimms deleted the issue-765-compute-grad-fem branch December 28, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

current collector ohmic heating in 2+1D
2 participants