Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comsol comparison failing #763

Closed
rtimms opened this issue Dec 17, 2019 · 0 comments · Fixed by #768
Closed

comsol comparison failing #763

rtimms opened this issue Dec 17, 2019 · 0 comments · Fixed by #768
Assignees
@valentinsulzer

Comments

@rtimms
Copy link
Contributor

rtimms commented Dec 17, 2019

the script compare_comsol_DFN is failing on master when trying to interpolate something for plotting (error is "ValueError: A value in x_new is above the interpolation range."). I cant seem to reproduce this locally
rtimms added a commit that referenced this issue Dec 17, 2019
@rtimms
#763 update comment
c93918c
@rtimms rtimms mentioned this issue Dec 17, 2019
Closed
8 tasks
@valentinsulzer valentinsulzer self-assigned this Dec 22, 2019
valentinsulzer added a commit that referenced this issue Dec 22, 2019
@valentinsulzer
#763 more informative error message
b623a40
valentinsulzer added a commit that referenced this issue Dec 22, 2019
@valentinsulzer
#763 extrapolate
3e31ab8
valentinsulzer added a commit that referenced this issue Dec 25, 2019
@valentinsulzer
#763 don't bound errors
de91e3b
valentinsulzer added a commit that referenced this issue Dec 26, 2019
@valentinsulzer
#763 fixing examples
790b744
@valentinsulzer valentinsulzer mentioned this issue Dec 27, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 763 compare comsol pybamm-team/PyBaMM
#763 update comment pybamm-team/PyBaMM
2 participants
@valentinsulzer @rtimms