-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometric input params #4665
Geometric input params #4665
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4665 +/- ##
===========================================
+ Coverage 99.22% 99.25% +0.02%
===========================================
Files 303 303
Lines 23070 23223 +153
===========================================
+ Hits 22891 23049 +158
+ Misses 179 174 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aabills looks great, just a few comments
Sorry, got late to the review, but that's great! Tagging @BradyPlanden as this will be relevant to PyBOP. |
Do reach out to me if you are interested in using it, it doesn't work with the "out of the box" pybamm models but its relatively straightforward to get it working with custom models |
Description
This pull request implements a
SymbolicUniform1DSubmesh
, which allows for geometric parameters, such as electrode thicknesses and particle sizes to bepybamm.InputParameter
's.Fixes #3649
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest
(or$ nox -s tests
)$ python -m pytest --doctest-plus src
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks: