Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discretise geometric parameters with SymbolicUniform mesh #625

Open
BradyPlanden opened this issue Jan 15, 2025 · 0 comments
Open

Discretise geometric parameters with SymbolicUniform mesh #625

BradyPlanden opened this issue Jan 15, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

PyBaMM v25.1 includes a new SymbolicUniform mesh type, enabling geometric parameters to be 'input' parameters to the PyBaMM solvers. This issue is to update our EChem model rebuild process to use the SymbolicMesh where possible for performance improvements alongside sensitivity information.

Motivation

No response

Possible implementation

PyBaMM PR: pybamm-team/PyBaMM#4665
PyBaMM example: https://github.com/pybamm-team/PyBaMM/blob/develop/docs/source/examples/notebooks/parameterization/geometric_parameters.ipynb

Additional context

No response

@BradyPlanden BradyPlanden added the enhancement New feature or request label Jan 15, 2025
@BradyPlanden BradyPlanden moved this to Todo in v25.3 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant