Fixes #4176 electrode diffusivity rename #4179
Merged
Commits on Jun 14, 2024
-
fix: revert logic change for failing 'particle diffusivity' key, updt…
…. check_parameter_values to rename depreciated key
-
fix: removes bpx remapping requirement, creates 'particle diffusivity…
…' without destroying 'electrode diffusivity', updts tests to verify functionality
-
Commits on Jun 18, 2024
-
-
Apply suggestions from code review
Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk> Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
3 people committedJun 18, 2024
Commits on Jun 19, 2024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.