Fixes #4176 electrode diffusivity rename

[BradyPlanden]

Description

Fixes #4176. In addition to this issue, in the develop implementation changes to electrode diffusivity via parameter_values.update() will not be captured. To account for this, the I've taken the depreciated key and appended the new key into parameter_set dictionary in the event that the depreciated parameter is supplied. This also cleans up the bpx.py implementation since the logic for changing the key is moved into the parameters class.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (088ca38) to head (c199d3e).
Report is 226 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4179   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          288      288           
  Lines        21799    21800    +1     
========================================
+ Hits         21708    21709    +1     
  Misses          91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agriyakhetarpal]

Hi @ejfdickinson, would be able to try these changes out? Also, thanks for flagging this at a reasonable time before the release and thank you @BradyPlanden for taking it!

[agriyakhetarpal]

Just one nitpicky typo suggestion – I don't understand the BPX code enough so I will leave it to someone else to approve but the rest of the changes look good to me, thanks!

[ejfdickinson]

@agriyakhetarpal @BradyPlanden The test I made is passing with these changes, so seems ok to me. Note also typoes in the changelog!

[brosaplanella]

Looks good to me, especially if it fixes @ejfdickinson example.