Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load function #1676

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Fix load function #1676

merged 4 commits into from
Sep 16, 2021

Conversation

brosaplanella
Copy link
Sponsor Member

Description

Fix the load_function bug on main branch.

Fixes #1673

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also manually increment version numbers

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1676 (84007d7) into main (6e8437f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1676   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files         343      343           
  Lines       18677    18680    +3     
=======================================
+ Hits        18540    18543    +3     
  Misses        137      137           
Impacted Files Coverage Δ
pybamm/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4adf0e7...84007d7. Read the comment docs.

@priyanshuone6
Copy link
Member

@brosaplanella could you also include changes from this PR to this release

Copy link
Member

@priyanshuone6 priyanshuone6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brosaplanella brosaplanella merged commit 02c0842 into main Sep 16, 2021
@brosaplanella brosaplanella deleted the release-21-8-1 branch September 16, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants