Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMakeBuild to package data #1672

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

priyanshuone6
Copy link
Member

Description

Add CMakeBuild.py to package data

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #1672 (96ea752) into develop (28ff4b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1672   +/-   ##
========================================
  Coverage    99.27%   99.27%           
========================================
  Files          342      342           
  Lines        18717    18717           
========================================
  Hits         18582    18582           
  Misses         135      135           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ff4b5...96ea752. Read the comment docs.

@valentinsulzer
Copy link
Member

Why is this needed?

@priyanshuone6
Copy link
Member Author

priyanshuone6 commented Sep 15, 2021

Tests are failing here because sdist has no CMakeBuild
Capture

@valentinsulzer valentinsulzer merged commit d5e818a into pybamm-team:develop Sep 15, 2021
@priyanshuone6 priyanshuone6 mentioned this pull request Sep 16, 2021
6 tasks
brosaplanella added a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants