Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1108 change t_eval list to linspace #1113

Merged
merged 4 commits into from
Jul 24, 2020
Merged

Conversation

valentinsulzer
Copy link
Member

Description

If a solver sees a list of length 2 for t_eval, change it to linspace
Fixes #1108

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #1113 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1113   +/-   ##
========================================
  Coverage    97.82%   97.82%           
========================================
  Files          245      245           
  Lines        13271    13273    +2     
========================================
+ Hits         12982    12984    +2     
  Misses         289      289           
Impacted Files Coverage Δ
pybamm/simulation.py 96.75% <100.00%> (-0.06%) ⬇️
pybamm/solvers/base_solver.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4c9bb...81c4e95. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 58e379b into develop Jul 24, 2020
@valentinsulzer valentinsulzer deleted the issue-1108-list-to-solver branch July 24, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing a list [t_0, t_end] directly to solver.solve
2 participants