Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing a list [t_0, t_end] directly to solver.solve #1108

Closed
valentinsulzer opened this issue Jul 20, 2020 · 0 comments · Fixed by #1113
Closed

Passing a list [t_0, t_end] directly to solver.solve #1108

valentinsulzer opened this issue Jul 20, 2020 · 0 comments · Fixed by #1113

Comments

@valentinsulzer
Copy link
Member

When passed a list t_eval=[t_0, t_end], the simulation turns it into a linspace. This should also be the case when using a solver directly, for consistency.
valentinsulzer added a commit that referenced this issue Jul 23, 2020
@valentinsulzer
#1108 change t_eval list to linspace
8d7ae3a
@valentinsulzer valentinsulzer mentioned this issue Jul 23, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Jul 24, 2020
@valentinsulzer
#1108 remove duplicate
63be994
valentinsulzer added a commit that referenced this issue Jul 24, 2020
@valentinsulzer
#1108 changelog
81c4e95
valentinsulzer added a commit that referenced this issue Jul 24, 2020
@valentinsulzer
Merge pull request #1113 from pybamm-team/issue-1108-list-to-solver
58e379b 
#1108 change t_eval list to linspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1108 change t_eval list to linspace pybamm-team/PyBaMM
1 participant
@valentinsulzer