Reorder effect arguments; allow scalar treatments #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbattocchi
force-pushed
the
kebatt/scalarTreatments
branch
2 times, most recently
from
a4ed8c7
to
3c4086b
Compare
|
Addresses #18 |
|
I suspect we might want to simplify our jupyter notebooks so that instead of the uglier: const_marginal_effect(X), we just call effect(X), whenever applicable. |
kbattocchi
force-pushed
the
kebatt/scalarTreatments
branch
2 times, most recently
from
180c9ae
to
9e552a6
Compare
|
@vasilismsr Updated the notebooks as requested. |
kbattocchi
force-pushed
the
kebatt/scalarTreatments
branch
from
9e552a6
to
5fff32a
Compare
vasilismsr
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.