Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow single-row values for T0 and T1 when computing the effect (with defaults 0 and 1) #18

Closed
kbattocchi opened this issue Mar 22, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kbattocchi
Copy link
Collaborator

In many cases (single treatment, single response models with binary treatments or linear responses) setting T0 to 0 and T1 to 1 for all rows of the data would be a sensible default that would save users from having to explicitly provide arrays.

@kbattocchi kbattocchi added the enhancement New feature or request label Mar 22, 2019
@kbattocchi kbattocchi added this to the v0.2 milestone Mar 22, 2019
@kbattocchi
Copy link
Collaborator Author

@vasilismsr @moprescu
I think this change will be a nice ergonomic improvement. However, should we also then reorder the arguments to effect so that T0 and T1 come last (i.e. effect(X=None, T0=0, T1=1))? Otherwise with the current signature the user would have to specify X as a keyword argument in the common case where it's not None (e.g. myModel.effect(X=X)) because otherwise it would be interpreted as the now optional T0 argument.

@vasilismsr
Copy link
Contributor

Yes. I agree! we should be able to say
model.effect(X)
for binary treatment models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants