Also store raw coverage information on data branch #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieferro
force-pushed
the
save-more-data
branch
from
8d1d5a9
to
16eb78d
Compare
This makes it possible to have more information than just the coverage rate when comparing a PR.
kieferro
force-pushed
the
save-more-data
branch
from
16eb78d
to
1d20d38
Compare
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)coverage_comment/main.py
coverage_comment/files.py
coverage_comment/coverage.py
|
ewjoachim
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares #211
With the current redesign for the new coverage comment, we need more information about the coverage on the default branch.
The easiest way to make sure that we have all the data we need, is to simply store the raw JSON coverage data on the coverage data branch.
This is not used yet, but the sooner we ship this change, the more repos will have a push event between this change and the merge of #211, which leads to more cases where all data is available.