Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve coverage comment #211

Merged
merged 15 commits into from
Jan 1, 2024
Merged

Improve coverage comment #211

merged 15 commits into from
Jan 1, 2024

Conversation

kieferro
Copy link
Member

@kieferro kieferro commented Jul 18, 2023 •
edited by ewjoachim
Loading

Fixes #189 and using comment designed in #235
This PR tries to make the coverage comment more readable and practical by:

  • adding links to the mentioned files
  • displaying consecutive uncovered lines as range (1-4 instead of 1, 2, 3, 4)
  • linking to missing lines in git diff
  • using badges to display basic coverage information
  • ... (more changes will follow)

This should be merged after #184, as coverage in subdirectories is something that needs to be considered when generating urls.

@kieferro kieferro linked an issue Jul 18, 2023 that may be closed by this pull request
Table as markdown output #189
Closed
@github-actions
Copy link

End-to-end public repo
End-to-end private repo
If the tests fail, @kieferro will be added to the private repo

@github-actions
Copy link

github-actions bot commented Jul 18, 2023 •
edited
Loading

Coverage report

The coverage rate went from 100% to 100% ➡️
The branch rate is 100%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

coverage_comment/badge.py

100% of new lines are covered (100% of the complete file).

coverage_comment/coverage.py

100% of new lines are covered (100% of the complete file).

coverage_comment/diff_grouper.py

100% of new lines are covered (100% of the complete file).

coverage_comment/files.py

100% of new lines are covered (100% of the complete file).

coverage_comment/groups.py

100% of new lines are covered (100% of the complete file).

coverage_comment/main.py

100% of new lines are covered (100% of the complete file).

coverage_comment/settings.py

100% of new lines are covered (100% of the complete file).

coverage_comment/template.py

100% of new lines are covered (100% of the complete file).

ewjoachim
ewjoachim reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just testing reviews, don't mind me.

@kieferro kieferro force-pushed the comment-improvements branch 2 times, most recently from 7438f63 to 0d0f0a1 Compare August 6, 2023 16:41
ewjoachim
ewjoachim reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments ! We're definitely going in the right direction, and approaching the goal !

coverage_comment/coverage.py Outdated Show resolved Hide resolved
tests/unit/test_template.py Outdated Show resolved Hide resolved
coverage_comment/coverage.py Outdated Show resolved Hide resolved
coverage_comment/template.py Outdated Show resolved Hide resolved
coverage_comment/template.py Outdated Show resolved Hide resolved
@kieferro kieferro force-pushed the comment-improvements branch 3 times, most recently from d2c3ab7 to 39ae4ea Compare August 30, 2023 00:48
@ewjoachim ewjoachim changed the base branch from v3 to main September 1, 2023 19:02
@ewjoachim ewjoachim mentioned this pull request Sep 2, 2023
Closed
@kieferro kieferro mentioned this pull request Sep 9, 2023
Merged
@kieferro kieferro mentioned this pull request Sep 21, 2023
Merged
@ewjoachim ewjoachim force-pushed the comment-improvements branch 2 times, most recently from c300fa0 to 747294b Compare December 29, 2023 11:35
@ewjoachim
Copy link
Member

Tests are all over the place, but we're generating comments that start to look as expected.

@ewjoachim ewjoachim mentioned this pull request Jan 1, 2024
Closed
@ewjoachim ewjoachim force-pushed the comment-improvements branch 2 times, most recently from eea7cba to fb8f291 Compare January 1, 2024 19:53
@ewjoachim ewjoachim marked this pull request as ready for review January 1, 2024 21:10
@ewjoachim ewjoachim mentioned this pull request Jan 1, 2024
Closed
@ewjoachim ewjoachim mentioned this pull request Jan 1, 2024
Closed
@ewjoachim ewjoachim merged commit a921cba into main Jan 1, 2024
2 checks passed
@ewjoachim ewjoachim deleted the comment-improvements branch January 1, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table as markdown output
2 participants
@kieferro @ewjoachim