Implement pvlib.irradiance.louche decomposition model
#1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confused in tests, shall I take subset of tests from |
|
Hey guys please have a look over the PR and let me know of any changes. |
cwhanse
reviewed
Mar 31, 2023
cwhanse
reviewed
Apr 3, 2023
cwhanse
reviewed
Apr 3, 2023
cwhanse
approved these changes
Apr 3, 2023
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
|
Thanks for the guidance @cwhanse. |
kandersolar
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Thanks @Lakshyadevelops! Here are some suggestions to make this code more consistent with pvlib conventions and the other irradiance decomposition functions.
Closed
|
@Lakshyadevelops do you think you'll be able to update this PR for the above comments? Let us know if not and we can finish it. Thanks :) |
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
cwhanse
approved these changes
May 29, 2023
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
kandersolar
approved these changes
May 30, 2023
kandersolar
changed the title
pvlib.irradiance.louche decomposition model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.