Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to basics for diffuse fraction functions #1753

Open
adriesse opened this issue May 30, 2023 · 2 comments
Open

Back to basics for diffuse fraction functions #1753

adriesse opened this issue May 30, 2023 · 2 comments

Comments

@adriesse
Copy link
Member

Is your feature request related to a problem? Please describe.
Our collection of diffuse fraction model functions (identified as DNI estimation models) is growing. Currently none of the functions supports the most basic usage I expect, which is to calculate diffuse fraction from kt.

Describe the solution you'd like
A set of diffuse fraction functions that take kt as input (and more kwargs if the model needs it) and produces diffuse fraction as output.
A higher level function could be provided to do the higher level task of decomposing ghi using a kwarg to select the model.

Describe alternatives you've considered
Implement my own versions of the functions locally, which I have done.

Additional context

#1128
#1179
#1685
#1705
#1730

@cwhanse
Copy link
Member

cwhanse commented May 30, 2023

@adriesse do you think we factor the diffuse fraction = f(kt) functions out of the various decomposition functions?

@adriesse
Copy link
Member Author

@cwhanse that's the gist of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants