Emberjs upgrade #526
Merged
Emberjs upgrade #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit #77c1a32 fixes view bug, all looks fine in frontend. Frontend tests in pipeline are stuck, I don't know why |
|
The app works without problems, the only problem is now the testing. Tests are failing, because there is a problem with ember-test-helpers. The files |
|
ToDo's:
|
lkleisa
force-pushed
the
feature/480-emberjs-upgrade
branch
5 times, most recently
from
73a84f1
to
32a1cdc
Compare
|
Frontend tests are running locally only if you disable the keycloak. You can start a testing backend with the following command: |
|
Locally, 14 Frontend Tests are failing, in the pipeline there are 18. There are some problems with dropdowns, there are no options which the tests could choose. |
lkleisa
force-pushed
the
feature/480-emberjs-upgrade
branch
from
8b81432
to
b9e2e07
Compare
|
App is currently working with 2 bugs:
|
…urce and add qunit
…rap version to 3 and update ember-bootstrap, ember-basic-dropdown and ember-power-select-with-create
…nt to 9.0.1 and add node-sass to dependencies
njaeggi
suggested changes
Apr 18, 2023
Closed
6 tasks
Robin481
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Only small things in the code, good job!
Concerning the functionality of the website:
- Person-Edit -> The save button doesn't have the correct css anymore
- Person-Edit -> Add a new
Funktiondon't fill all of its fields and save -> you will get an error message. Then if you correctly fill out all the fields and save again the save doesn't happen anymore. -> Check if this is a new thing with your update or already a problem on the main branch. If it is the latter just make an issue please :) -> Is also on production, here is the issue - Same problem as above with Person-Edit -> Languages -> Same issue as above
- Pressing
reset Skillon a filled out Skill breaks all the bubbles on the current site. I am assuming that this is very similar to the other problems you solved so this shouldn't take too long. If it would take a long time however just create an issue please. - Skills -> Editing one of the skills close to the bottom, sometimes the grey bar at the bottom that contains the current Skills version will jump up. Again if it is already a thing on main create an issue.
- Skills -> When all available skills are rated the bubbles break. They don't break if you sort by rated however.
Besides that it looks really good! 🥳 Good Job!
lkleisa
force-pushed
the
feature/480-emberjs-upgrade
branch
from
1c3b598
to
70ff755
Compare
lkleisa
commented
Apr 18, 2023
lkleisa
commented
Apr 19, 2023
lkleisa
commented
Apr 19, 2023
lkleisa
commented
Apr 19, 2023
mtnstar
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
nice, a huge PR with an awesome upgrade! 🥳
some small comments you might check. I did not start the application locally for testing as I assume more than one team member did that already.
is there a reason why there's still some jQuery syntax left? you got rid of most of it.
check some small comments ... otherwise go for it 🚀
Robin481
approved these changes
Apr 20, 2023
kcinay055679
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Upgrade ember to 3.18.0 * Upgrade ember to 3.19.0 * Upgrade ember to 3.20.0 * Upgrade ember to 3.21.0 * Upgrade ember to 3.22.0 * Upgrade ember to 3.23.0 * Remove ember-fetch * Upgrade ember to 3.24.0 * Upgrade ember-cli-string-helpers * Upgrade nodejs version to 14.19.0 * Upgrade ember-qunit * Upgrade ember to 3.28.0, ember-auto-import, ember-bootstrap, ember-source and add qunit * Upgrade ember to 3.28.6, add custom ember-cli-icon-rating, set bootstrap version to 3 and update ember-bootstrap, ember-basic-dropdown and ember-power-select-with-create * Upgrade ember-cli-sass to 10.0.1, bootstrap-sass to 3.4.1, ember-moment to 9.0.1 and add node-sass to dependencies * Upgrade ember-cli-babel to 7.26.11 * Upgrade ember-data to 3.28.13 * Upgrade ember-cli-htmlbars to 5.7.2 * Upgrade rollup to 1.12.0 * Update browser list * Update ember-modifier, ember-power-select-with-create and add @ember/string * Update multiple dependencies (@ember/render-modifiers, ember-intl, ember-validated-form, ember-changeset-validations, ember-cli-app-version, ember-collapsible-panel, ember-confirm-dialog, ember-keyboard, ember-notify, ember-simple-auth, ember-toggle) * Upgrade ember-bootstrap and use bootstrap 4 * Upgrade @ember/optional-features and remove unused config * Upgrade ember-route-action-helper * Use qunit for test method and not ember-qunit * Fix not running frontend tests * Update yarn.lock and fix dependency alert * Add qunit setup to ember test helpers * Add @service annotation for this.store * Set jquery-integration to false * Make submit button blue * Downgrade ember-keyboard to 6.0.4 * Fix jquery bug * Regenerate yarn.lock file * Make eslint happy * Upgrade jquery * Replace this.$() with $() * Change ember version in rails.yml * Add allowed versions to dependency-lint.js * Upgrade qunit-dom * Fix testing errors with qunit-dom * Fix locale error in tests * Remove import from $ jquery in tests * Replace jquery with querySelector in person-cv-export-test * Try fixing test problems with document queryselector * Replace document with this.element * Revert document querySelector to assert.dom * Set locale in new-people-skills-show-test * Add ember-fetch * Fix failing tests, remove $.text() and replace this.render with await render * Replace $ with document.querySelector * Remove dependency lint error * Update yarn.lock * Remove person form tests because they will be new in feature #351 * Add @initiallyOpened={{false}} and @renderInPlace={{true}} to Ember Power Selects * Fix daterange-edit-tests with this.$ error * Remove css bug with header menu over drop down * Remove bug with not possible to delete person * Remove bug with overlay from people search on person delete * Fix tests in frontend * Remove unused eslint disable * Move button styling to custom.scss * Adjust readme with specific ember cli version * Fix tests in frontend * Resolve bug with setting something on deleted record * Adjust eslint disabling * Fix pipeline bug with calling set on destroyed record * Remove outcommented rootElement = "ember-testing" * Revert changes in skill-search-test.js * Implement feedback from pr * Fix bug with 2 times clicking on new skill in skill set * Fix pipeline bug with calling set on destroyed record * Fix failing text * Remove bug with multiple selection of ui slider * Fix bug with first point of ui slider always dark blue marked * Resolve pr review * Fix bug when editing people skills * Remove outcommented code * Fix failing test people skill edit * Resolve pr feedback * Fix bug with resetting people skill and broken slider bubbles * Replace sleep with setTimeout * Remove bubbles bug when editing all people skills * Resolve pr feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #480