Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EmberJS Version #480

Closed
6 tasks done
Robin481 opened this issue Dec 5, 2022 · 1 comment · Fixed by #526
Closed
6 tasks done

Update EmberJS Version #480

Robin481 opened this issue Dec 5, 2022 · 1 comment · Fixed by #526
Assignees
Labels
plan needs to be planned

Comments

@Robin481
Copy link
Member

Robin481 commented Dec 5, 2022

We are quite a bit behind now and should probably update the EmberJS version.

As this is hard to plan without knowing what changes in all the different versions this should probably be done in a timeboxed manner for a few versions at a time.

For now timeboxed to 24 hours
TODO:

  • Update Ember Versions step by step
  • Keep Update Node LTS Version #496 in mind as you probably need to update the Node Version along the way anyways.
  • Check that in this new state the EmberJS specific security advisories are also fixed
  • Upgrade Boostrap to 4 or even 5
  • Make sure tests still pass after each step
  • Smoke Tests after each step
@Robin481 Robin481 added the plan needs to be planned label Jan 30, 2023
@Robin481 Robin481 mentioned this issue Feb 17, 2023
2 tasks
@Robin481 Robin481 changed the title Update EmberJS Version (5) Update EmberJS Version Feb 27, 2023
@lkleisa lkleisa self-assigned this Mar 6, 2023
@lkleisa
Copy link
Collaborator

lkleisa commented Mar 10, 2023

Long time ago (today), someone took 16 hours time to upgrade our emberjs frontend. It went well until version 3.28.0.
This ticket was stopped with the result of a new branch and an upgrade of emberjs from 3.17.0 to 3.24.0. Node stayed the same on this branch (on the new, there is an upgrade from 12 to 14).
There were multiple errors after the upgrade to emberjs 3.28.0, and I tried to fix them step by step.
What I tried after emberjs 3.24.0 (on the new branch):

  • Commit 60a4eb7: I've updated ember-cli-string-helpers from 2.0.0 to 6.1.0
  • Commit 5deba21: I've updated @ember/test-helpers from 1.7.1 to 2.9.3
  • Commit 5deba21: I've updated node version from 12 to 14 (locally, I used v14.19.0)
  • Commit d661eb4: I've updated ember-qunit from 4.1.1 to 6.2.0
  • Commit 600c8e2: I've upgraded emberjs version from 3.24.0 to 3.28.0
    After this, there was a problem, which is still a bug from ember: [Bug] Some addons fail ember:try scenarios with ember-release (3.25) with loc$$1.sliceStartChars is not a function emberjs/ember.js#19432
    Therefore, I've set the bootstrap version in frontend/ember-cli-build.js to 3, updated ember-bootstrap from 3.1.1 to 4.9.0 and ember-popper from 0.10.3 to 0.11.3
    After this, there was a problem with font awesome. Because last ember-font-awesome support was 4 years ago, it's recommended to use FortAwesome. The problem is, that we use ember-font-awesome in another dependency (ember-cli-icon-rating). Because of that, I forked ember-cli-icon-rating and replaced ember-font-awesome with ember-fontawesome. This fork is here.
    I've added the fork in package.json. I don't know if the change to ember-fontawesome works 100% in puzzle skills, but the fork of its own works.
    Now, there is a problem while ember build, which I couldn't fix in this 16 hours.

@lkleisa lkleisa mentioned this issue Mar 10, 2023
@Robin481 Robin481 changed the title (5) Update EmberJS Version Update EmberJS Version Mar 13, 2023
@lkleisa lkleisa linked a pull request Apr 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan needs to be planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants