Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make possible to customize fish_right_prompt #104

Merged
merged 7 commits into from
Jan 8, 2019
Merged

Make possible to customize fish_right_prompt #104

merged 7 commits into from
Jan 8, 2019

Conversation

filipebarros
Copy link
Contributor

@filipebarros filipebarros commented Dec 19, 2018 •
edited by edouard-lopez
Loading

related: #87

Issue:

  • Updating pure overrides the fish_right_prompt.fish file, replacing
    it with it's own content

Why:

  • It's annoying that we need to set it again once we update pure

Improvements

  • Add pure_right_prompt customizing the message
  • Add pure_right_prompt_color customizing the color of the message

Example:

set pure_right_prompt '['(rbenv version-name)']'
set pure_right_prompt_color red

Outcome:
image

@edouard-lopez
Copy link
Member

@filipebarros Thanks for your PR, I'm sorry for the delay, it's due to the fact I'm working on #96 to add tests prior to new PRs.

edouard-lopez
edouard-lopez previously requested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@edouard-lopez edouard-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase your PR and resolve conflicts as we merge a lot of code since you submitted it?
Ping me if you need help

fish_right_prompt.fish Outdated Show resolved Hide resolved
@filipebarros
Copy link
Contributor Author

@edouard-lopez rebased

filipebarros and others added 6 commits January 8, 2019 15:45
@filipebarros @edouard-lopez
Make possible to customize fish_right_prompt
b498f14 
Issue:
* Updating pure overrides the `fish_right_prompt.fish` file, replacing
it with it's own content

Why:
* It's annoying that we need to set it again once we update pure

Improvements
* Add `pure_right_prompt` customizing the message
* Add `pure_right_prompt_color` customizing the color of the message
@edouard-lopez
test configurations related to right_prompt (content, color)
0050e23
@edouard-lopez
fix pure_right_prompt_color value (should be a variable)
03e6a78
@edouard-lopez
rename $pure_color_right_prompt variable to follow our conventions
1f3d0d1
@edouard-lopez
test fish_right_prompt.fish
5eef3d7
@edouard-lopez
refactor fish_right_prompt.fish
6ef5862
edouard-lopez added a commit that referenced this pull request Jan 8, 2019
@edouard-lopez
update version: 1.13.0
1a2a371 
see #104
@edouard-lopez edouard-lopez merged commit 0818bc9 into pure-fish:master Jan 8, 2019
@edouard-lopez
Copy link
Member

Thanks @filipebarros, it's merged 👏

⚠️ Note that I renamed the variable to be consistent with our convention:

# Right Prompt variables
_pure_set_default pure_right_prompt ""
_pure_set_default pure_color_right_prompt $pure_color_normal

@edouard-lopez edouard-lopez mentioned this pull request Jan 8, 2019
Closed
edouard-lopez added a commit that referenced this pull request Aug 21, 2023
@edouard-lopez
update version: 1.13.0
148cc95 
see #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edouard-lopez edouard-lopez edouard-lopez left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipebarros @edouard-lopez