Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding definition of fish_right_prompt.fish #87

Closed
filipebarros opened this issue Oct 22, 2018 · 4 comments
Closed

Overriding definition of fish_right_prompt.fish #87

filipebarros opened this issue Oct 22, 2018 · 4 comments
Labels
⭐️ idea feature request or suggestion

Comments

@filipebarros
Copy link
Contributor

At the moment, installing this plugin always overrides the fish_right_prompt.fish.

Can we just remove the fish_right_prompt.fish so it doesn't change the user defined fish_right_prompt.fish ?

@rafaelrinaldi
Copy link
Collaborator

This is interesting... We do that to make sure the theme looks consistent accross the board but I can see this is annoying. Maybe we can keep overriding the file itself but instead of simply setting it to empty we can try to read it from the user environment. Something like:

set -l right_prompt (fish_right_prompt or "")

What do you think?

@rafaelrinaldi rafaelrinaldi added the ⭐️ idea feature request or suggestion label Dec 14, 2018
@rafaelrinaldi
Copy link
Collaborator

@filipebarros Would you be willing to open a PR with this implemented? I'd be happy to review it and merge it in.

@filipebarros
Copy link
Contributor Author

sure, I'll give it a go

@edouard-lopez
Copy link
Member

closed by #104, available in 1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ idea feature request or suggestion
Projects
None yet
Development

No branches or pull requests

3 participants