(DIO-2833) Connect domain settings to pools, create v2 API #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbeaulie
reviewed
Dec 30, 2021
sbeaulie
reviewed
Dec 30, 2021
sbeaulie
reviewed
Dec 30, 2021
genebean
changed the title
|
I will be resuming this work today |
genebean
force-pushed
the
sut_domain
branch
5 times, most recently
from
64a50c8 to
7e97c57
Compare
sbeaulie
reviewed
Jan 11, 2022
genebean
force-pushed
the
sut_domain
branch
4 times, most recently
from
6ae6ed1 to
7273efb
Compare
genebean
changed the title
genebean
force-pushed
the
sut_domain
branch
7 times, most recently
from
0d54579 to
45e536a
Compare
yachub
reviewed
Mar 30, 2022
sbeaulie
force-pushed
the
sut_domain
branch
2 times, most recently
from
a6b1fc5 to
932ceb4
Compare
the vm_ready methods should be implemented per provider and checking in the api creates issues since provider code is not available. Removing this for the V2 api
yachub
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API V2
There are changes needed to support domains being configurable per pool that will require breaking changes to the API. For this reason a V2 API is being introduced as part of this PR. The V2 API is intended to be minimally different than the V1 with the following key differences: