Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(DIO-3101) Add VMPooler API v2 Support #158

Merged
merged 2 commits into from
Apr 5, 2022
Merged

(DIO-3101) Add VMPooler API v2 Support #158

merged 2 commits into from
Apr 5, 2022

Conversation

yachub
Copy link

@yachub yachub commented Apr 1, 2022 •
edited
Loading

Description

Adds support for VMPooler API v2 as part of puppetlabs/vmpooler#475

Using this version of code I verified the following scenarios:

  • get pooled VMs from ABS with different domains
  • get ondemand VMs from ABS with different domains
  • get ondemand VMS with different domains from VMPooler API v2
  • get ondemand VMS from VMPooler API v1
  • get pooled VMs from VMPooler API v1
  • get pooled VMs from VMPooler API v2
  • ssh with single ondemand VM via VMPooler API v1
  • ssh with multiple ondemand VM via VMPooler API v1
  • ssh with single ondemand VM via VMPooler API v2
  • ssh with multiple ondemand VM via VMPooler API v2
  • ssh with single pooled VM via VMPooler API v1
  • ssh with multiple pooled VM via VMPooler API v1
  • ssh with single pooled VM via VMPooler API v2
  • ssh with multiple pooled VM via VMPooler API v2

@yachub yachub force-pushed the vmpooler-api-v2 branch from a2b07b6 to 7242ac8 Compare April 4, 2022 15:14
@yachub yachub marked this pull request as ready for review April 4, 2022 15:19
@yachub yachub requested a review from a team as a code owner April 4, 2022 15:19
@yachub yachub force-pushed the vmpooler-api-v2 branch from 7242ac8 to 7d65d3d Compare April 4, 2022 15:43
@yachub
Copy link
Author

yachub commented Apr 4, 2022

Just rebased to get the new checks in.

sbeaulie
sbeaulie reviewed Apr 4, 2022
View reviewed changes
lib/vmfloaty/utils.rb Outdated Show resolved Hide resolved
sbeaulie
sbeaulie reviewed Apr 4, 2022
View reviewed changes
spec/vmfloaty/ssh_spec.rb Outdated Show resolved Hide resolved
sbeaulie
sbeaulie reviewed Apr 4, 2022
View reviewed changes
lib/vmfloaty/ssh.rb Outdated Show resolved Hide resolved
@yachub yachub force-pushed the vmpooler-api-v2 branch 2 times, most recently from e7aaf87 to 57251ed Compare April 5, 2022 12:17
sbeaulie
sbeaulie reviewed Apr 5, 2022
View reviewed changes
spec/vmfloaty/ssh_spec.rb Outdated Show resolved Hide resolved
@yachub yachub force-pushed the vmpooler-api-v2 branch from 57251ed to 667dacb Compare April 5, 2022 15:41
@yachub yachub merged commit 8f7487b into main Apr 5, 2022
@yachub yachub deleted the vmpooler-api-v2 branch April 5, 2022 15:43
yachub added a commit that referenced this pull request Apr 5, 2022
@yachub
v1.7.0 release prep
f74fe22 
Includes the following PRs since the last release:
- #157
- #160
- #159
- #155
- #152
- #158
@yachub yachub mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbeaulie sbeaulie sbeaulie approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yachub @sbeaulie