Allow custom library paths and module identifier names #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset will allow users to set custom module identifier string similar
to module package name and module library name. For example, module identifier
string for shibboleth can be set as:
$mod_identifiers = {
'shibboleth' => 'mod_shib',
}
See github #1 for details.
See github #2 for details. Allowed user to specify custom module library .so file location using an absolute path. If the module library location string starts with a forward slash '/', then the path is taken as an absolute path. Otherwise, a relative path from default 'modules' directory is taken.
|
Thanks! I +1 this but want a second review. |
|
|
||
| # Set libfile path: If absolute path is passed then maintain it, else make it default 'modules/module-name' | ||
| def libfile | ||
| abs_path_regex = /^\/.*/ |
There was a problem hiding this comment.
Ruby has functions for checking if a path is absolute. That would be much clearer than a hand-rolled regex here
|
Thanks for the suggestion @branan. Updated code to use Ruby's pathname library for absolute/relative path check. Also, added module identifier parameter to a2mod resource and default parameters list. |
|
ping |
|
Right! Thanks for pinging. |
hunner
added a commit
that referenced
this pull request
Oct 10, 2012
Allow custom library paths and module identifier names
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
docker::registry fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned below are two commits in this pull-request:
Any comments or questions are welcome.