Add new parameter to set httpd module identifier string

[knowshan]

The apache module identifier string is used by LoadModule directive while loading the module. Many modules follow convention of setting it as "$modulename_module", however, there are few exceptions. Hence, it should be a configurable parameter with default as "$modulename_module".

[lboynton]

I get this with your changes: Error 400 on SERVER: Invalid parameter identifier at /etc/puppet/modules/apache/manifests/mod.pp:40

On CentOS 6.3.

[knowshan]

@lboynton Sorry for the late reply.

I couldn't replicate this issue on my CentOS 6.3 system with Puppet 2.7.19. I am using revision eb1d004 with following entries in default node manifest.

class {'apache':  }
class {'apache::mod::ssl': }
apache::mod { 'xsendfile':
  package => 'mod_xsendfile',
 }
apache::mod { 'shibboleth': }

The 'identifier' parameter is defined in lib/puppet/type/a2mod.rb, so I am not sure why it's complaining. Can you provide Puppet version and apache module's git revision number?

[andyshinn]

I'm having the same issue on puppetlabs/puppetlabs-apache@eb1d004. I am using CentOS 6.3 and Puppet 3.0.1-1 RPMs from Puppetlabs yum repo. I'm trying to do some debugging to figure out what might be happening.

[knowshan]

I haven't got any problems with Puppet 2.7. I am on vacation with limited connectivity, so I can debug it further with Puppet 3.0 after couple of weeks. Sorry for the inconvenience.

[lboynton]

The issue went away for me, I don't know if something was cached perhaps.

[andyshinn]

@lboynton, You haven't changed any other modules or Puppet version since the problem? Can you let me know which commit you are using as your module and Puppet version?

[knowshan]

@andyshinn I tried it on a fresh CentOS 6.3 install with Puppet 3.0.1, Ruby 1.8.7 and following module revisions:

c26e6af where this commit was introduced: No errors like 'Error 400 on SERVER: Invalid parameter identifier'
eb1d004 which you had mentioned earlier: No errors like 'Error 400 on SERVER: Invalid parameter identifier'
4ffb572 latest revision as of now: it returned following error related to validate_bool, but not invalid parameter identifier

....
Dec 11 02:05:29 localhost puppet-master[3416]: Unknown function validate_bool at /etc/puppet/modules/apache/manifests/init.pp:29 on node localhost.localdomain
Dec 11 02:05:29 localhost puppet-agent[5535]: Could not retrieve catalog from remote server: Error 400 on SERVER: Unknown function validate_bool at /etc/puppet/modules/apache/manifests/init.pp:29 on node localhost.localdomain
....

I will try to look into this again, but I am not seeing errors right now.

[andyshinn]

I finally tracked down my issue to this upstream bug http://projects.puppetlabs.com/issues/12173 - just in case someone else was having a similar issue which reared its head from this module. It isn't actually any fault of this Apache module! Not sure if @lboynton was running in to the same thing... This issue can probably be closed since the changes do actually work.