Fix RedHat + PHP 8 libphp file

[polatsinan]

Fixes loading correct libphp file when RedHat AND PHP 8.
Fixes #2332

[CLAassistant]

All committers have signed the CLA.

[puppet-community-rangefinder]

apache::mod::php is a class

Breaking changes to this file WILL impact these 49 modules (exact match):

• jlondon-phpmyadmin
• geoffwilliams-r_profile
• puppetlabs-awsdemo_profiles
• gajdaw-symfony
• puppetlabs-wordpress_app
• sgnl05-racktables
• shoekstra-owncloud
• binford2k-drupal
• jgazeley-speedtest
• rendhalver-icinga
• brucem-ezpublish
• wyrie-nagiosql
• lightoze-bacula
• martasd-mediawiki
• abstractit-icinga
• cirrax-postfixadmin
• SchnWalter-happydev
• gajdaw-phpmyadmin
• glarizza-profiles
• aimonb-nexusis_mediawiki
• nubevps-wordpress
• alexggolovin-lamp
• stesie-gluon
• hexmode-mediawiki
• datacentred-nfsen
• jgazeley-nagios
• Firebladee-moodle
• pieterdp-hx_apache
• martialblog-limesurvey
• monkygames-beansbooks
• zyronix-dokuwiki
• treydock-xdmod
• cirrax-autoconfigmail
• cirrax-roundcube
• thexa4-secrets_server
• southernhill-phpldapadmin
• pkumarnath-myapp
• snaragoni-myapp
• vinish098-myapp
• sasireddyfm-myapp
• pwaghray-myapp
• kumarmks6-myapp
• ganeshselva95-myapp
• premkumarp-myapp
• ranjithsimple-myapp
• devika-myapp
• tejoyasha-myapp
• benjaminrobertson-observium
• fancyolaya-dokuwiki

Breaking changes to this file MAY impact these 36 modules (near match):

• pltraining-dockeragent
• knowshan-phppgadmin
• eupathdb-ebrc_httpd_setup
• rspiak-racktables
• puppetfinland-librenms
• byjupv-mediakwiki
• gururaj-mediawiki
• suvarnagodri-mediawiki
• dbsrinivasulu-mediawiki
• pbhutani-mediawiki
• samuelson-dockeragent
• jaysingh-mediawiki
• hegdec-mediawiki
• gsachar1-mediawiki
• parthitraining-mediawiki
• esakazmi-mediawiki
• preethi-mediawiki
• pia-mediawiki
• hemantgangwar-mediawiki
• manish1984-mediawiki
• vinaycharles-mediawiki
• funaccount-mediawiki
• narenv-mediawiki
• webserve-mediawiki
• prakash007-mediawiki
• abhaysoni-mediawiki
• raviforge-mediawiki
• shantanumalik-mediawiki
• ravishankar1jan-mediawiki
• 214310-mediawiki
• kiranhosamani-mediawiki
• anthomas-mediawiki
• niksv-mediawiki
• nitish741-mediawiki
• mithilas-mediawiki
• sunilh-mediawiki

This module is declared in 174 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[ekohl]

This matches line 96 to line 47 so 👍 from that perspective. I'd really like some tests in spec/classes/mod/php_spec.rb for this. Do you think you could write some?

[ekohl]

@polatsinan could you have a look at writing a test?

[ekohl]

Thanks!

[david22swan]

LGTM

Look's like a good change to me :)
Thanks for putting in the work