Allow integers for timeouts

[traylenator]

Timeouts are more naturally written as integers, allow them.

We have run with integers here for many years.

[puppet-community-rangefinder]

apache::mod::auth_cas is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

• osc-openondemand

apache::mod::proxy is a class

Breaking changes to this file WILL impact these 16 modules (exact match):

• osc-openondemand
• kritz-vagrantlamp
• abiquo-abiquo
• landcareresearch-pidservice
• bp85-mirror_repos
• monkygames-landscape
• urgi-galaxy_roles_profiles
• pieterdp-hx_apache
• katello-crane
• zordrak-puppet
• openstack-ceph
• zivtech-drupal_php
• cristifalcas-kibana
• puppet-zabbix
• conzar-pidservice
• katello-pulp

Breaking changes to this file MAY impact these 2 modules (near match):

• eupathdb-ebrc_httpd_setup
• icinga-icinga

This module is declared in 174 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[traylenator]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The CLA is signed on behalf of CERN IT.

[ekohl]

In ae56cc9 initial data types were added and in f41251e we replaced a lot of the Strings with Integers, but clearly missed this.

#2290 is another instance of this. There I suggested to support a Variant (as you did here) and in #2291 we're making notes to drop the compatibility in the next major version. It looks like your PR would supersede #2290.

[traylenator]

In ae56cc9 initial data types were added and in f41251e we replaced a lot of the Strings with Integers, but clearly missed this.

#2290 is another instance of this. There I suggested to support a Variant (as you did here) and in #2291 we're making notes to drop the compatibility in the next major version. It looks like your PR would supersede #2290.

Agreed supersedes #2290 - should have looked first of course.

[ekohl]

I recall your org has signed the CLA, but the check is wrong. @david22swan @traylenator can you figure this out? The code looks good and solves a regression. After this a new release would be good to have.

[david22swan]

LGTM
Thank's for putting up the fix :)

As for the CLI, I'll take your word for it.
It's been buggy ever since it was implemented and this can happen.