Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout param issue in mod::proxy #2286

Closed
robertc99 opened this issue Aug 10, 2022 · 2 comments · Fixed by #2294
Closed

timeout param issue in mod::proxy #2286

robertc99 opened this issue Aug 10, 2022 · 2 comments · Fixed by #2294

Comments

@robertc99
Copy link

Version 8 has set the type of apache::mod::proxy::proxy_timeout as undef or string. It should be undef or integer.
proxy_iobuffersize should probably also be integer.

@robertc99 robertc99 changed the title timout param issue in mod::proxy timeout param issue in mod::proxy Aug 10, 2022
@ekohl
Copy link
Collaborator

ekohl commented Aug 10, 2022

So this is:

Optional[String] $proxy_timeout = undef,

The docs are https://httpd.apache.org/docs/2.4/mod/mod_proxy.html#proxytimeout and those say it is in seconds, so Integer makes sense. Probably even Integer[0] since negative values are unsupported AFAIK.

Could you come up with a PR?

@ekohl
Copy link
Collaborator

ekohl commented Aug 17, 2022

Fixed in #2294

@ekohl ekohl closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants