(PDOC-30) Fix Markdown parsing lists parsing #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transformer comment matching regex matched all whitespace after a comment. Lines which were effectively "blank" and just had a comment would be erased. Markdown lists need to end with a blank line. This messed up markdown formatting. The culprit is the regex /^\s*#\s/ which matches all of the comment ' #\n', however we want to leave the newline alone for markdown to parse. We replace the regex with /^\s*#[ \t]/ which will only match tabs or spaces after the hash and leave our beloved newline alone.
iankronquist
force-pushed
the
markdown-madness/PDOC-30
branch
from
110526a to
6137e94
Compare
|
I will merge this once we sort out the CI failures 👍 |
HAIL9000
added a commit
that referenced
this pull request
Jul 20, 2015
(PDOC-30) Fix Markdown parsing lists parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transformer comment matching regex matched all whitespace after a comment.
Lines which were effectively "blank" and just had a comment would be erased.
Markdown lists need to end with a blank line. This messed up markdown
formatting.
The culprit is the regex /^\s_#\s/ which matches all of the comment ' #\n',
however we want to leave the newline alone for markdown to parse.
We replace the regex with /^\s_#[ \t]/ which will only match tabs or spaces
after the hash and leave our beloved newline alone.
Fixes PDOC 30 on JIRA