Skip to content

Commit

Permalink
Merge pull request #37 from iankronquist/markdown-madness/PDOC-30
Browse files Browse the repository at this point in the history
(PDOC-30) Fix Markdown parsing lists parsing
  • Loading branch information
HAIL9000 committed Jul 20, 2015
2 parents 36a5e12 + 6137e94 commit 0d8c4e7
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
9 changes: 8 additions & 1 deletion lib/puppet_x/puppetlabs/strings/pops/yard_statement.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,14 @@ def extract_comments
# FIXME: The gsub trims comments, but is extremely optimistic: It
# assumes only one space separates the comment body from the
# comment character.
comments.unshift line.gsub(/^\s*#\s/, '')
# NOTE: We cannot just trim any amount of whitespace as indentation
# is sometimes significant in markdown. We would need a real parser.

# Comments which begin with some whitespace, a hash and then some
# tabs and spaces should be scrubbed. Comments which just have a
# solitary hash then a newline should keep that newline since newlines
# are significant in markdown.
comments.unshift line.gsub(/^\s*#[\t ]/, '').gsub(/^\s*#\n/, "\n")
else
# No comment found on this line. We must be done piecing together a
# comment block.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def the_definedtype()

parse(puppet_code, :puppet)

comment = "Definition: foo::bar\nThis class does some stuff"
comment = "Definition: foo::bar\n\nThis class does some stuff"
expect(the_definedtype).to document_a(:type => :definedtype, :docstring => comment)
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class foo::bar { }

parse(puppet_code, :puppet)

comment = "Class: foo::bar\nThis class does some stuff"
comment = "Class: foo::bar\n\nThis class does some stuff"
expect(the_hostclass).to document_a(:type => :hostclass, :docstring => comment)
end

Expand Down

0 comments on commit 0d8c4e7

Please sign in to comment.