-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unban label for banned user #9230
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9230 +/- ##
=======================================
Coverage ? 77.89%
=======================================
Files ? 100
Lines ? 5953
Branches ? 0
=======================================
Hits ? 4637
Misses ? 1316
Partials ? 0 |
Hi @imajit, maybe we could have the the icon + the text in red for banning...and when banned have the unban text to green..something like what we have in thoughts? |
Code Climate has analyzed commit 5bba626 and detected 0 issues on this pull request. View more on Code Climate. |
@cesswairimu @jywarren can you please review this |
Hi @imajit this is a good start..did you want to add tests for this functionality? No biggie if not, we could add a follow up issue for that after this is merged. Thanks |
Hi @imajit based on our conversation, I will go ahead and merge this and keep the issue open until the tests are implemented....feel free to pick it later if interested Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
* Unban label for banned user * Changed label format Co-authored-by: imajit <ajit.171it233@nitk.edu.in>
* Unban label for banned user * Changed label format Co-authored-by: imajit <ajit.171it233@nitk.edu.in>
Fixes #7507
![unbannw](https://user-images.githubusercontent.com/38528640/108889782-c2963b80-7632-11eb-8b9d-fd1bcfbfbf7e.gif)
I have changed the
See Full Profile
label toUnban on profile
for banned users. I have also changed the background similar to/spam
Current working
After changes
![unbanw2](https://user-images.githubusercontent.com/38528640/109210476-e0020b80-77d2-11eb-9f76-2b28cff5c474.gif)