Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unban label for banned user #9230

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Unban label for banned user #9230

merged 2 commits into from
Mar 18, 2021

Conversation

imajit
Copy link
Contributor

@imajit imajit commented Feb 23, 2021

Fixes #7507
I have changed the See Full Profile label to Unban on profile for banned users. I have also changed the background similar to /spam
Current working
unbannw

After changes
unbanw2

@imajit imajit requested a review from a team as a code owner February 23, 2021 19:01
@gitpod-io
Copy link

gitpod-io bot commented Feb 23, 2021

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@ac9c85e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9230   +/-   ##
=======================================
  Coverage        ?   77.89%           
=======================================
  Files           ?      100           
  Lines           ?     5953           
  Branches        ?        0           
=======================================
  Hits            ?     4637           
  Misses          ?     1316           
  Partials        ?        0           

@cesswairimu
Copy link
Collaborator

Hi @imajit, maybe we could have the the icon + the text in red for banning...and when banned have the unban text to green..something like what we have in /spam for consistency..you can check this locally if logged in as admin but it looks like this

Screenshot from 2021-02-25 21-13-08
Screenshot from 2021-02-25 21-13-29

thoughts?
Thanks for working on this

@codeclimate
Copy link

codeclimate bot commented Feb 25, 2021

Code Climate has analyzed commit 5bba626 and detected 0 issues on this pull request.

View more on Code Climate.

@imajit imajit changed the title [WIP] Unban label for banned user Unban label for banned user Feb 25, 2021
@imajit
Copy link
Contributor Author

imajit commented Mar 7, 2021

@cesswairimu @jywarren can you please review this

@cesswairimu
Copy link
Collaborator

Hi @imajit this is a good start..did you want to add tests for this functionality? No biggie if not, we could add a follow up issue for that after this is merged. Thanks

@cesswairimu
Copy link
Collaborator

Hi @imajit based on our conversation, I will go ahead and merge this and keep the issue open until the tests are implemented....feel free to pick it later if interested Thanks

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cesswairimu cesswairimu merged commit 01242e5 into publiclab:main Mar 18, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Unban label for banned user

* Changed label format

Co-authored-by: imajit <ajit.171it233@nitk.edu.in>
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Unban label for banned user

* Changed label format

Co-authored-by: imajit <ajit.171it233@nitk.edu.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the unban functionality
2 participants