Enhance the unban functionality

[sssash18]

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?
Currently if a user is banned the admin has to go to it's profile to unban the user.I would be better if the admin is provided with the unban option in the dropdown itself.
Current Behaviour

What did you expect to see that you didn't?

Please show us where to look

https://publiclab.org/ ...

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

---

Update from @jywarren

Hi, i think one issue here is that we are aiming to have very maintainable code and so are a little hesitant to add complex interfaces in duplicate. I wonder if we could do 2 things:

1. could we format the banned label a bit? Off topic, but it looks a little funny, no?
2. could we have, on a second line in the popup, something that says Unban on profile and link to the profile? this wouldn't require a test to protect new functionality and is pretty simple.

[sssash18]

@SidharthBansal @nstjean @cesswairimu @VladimirMikulic I would like to solve this one.Thanks

[VladimirMikulic]

@sssash18 the is issue is unclear. In your case, the user has already been banned.

[sssash18]

@VladimirMikulic I think now it's fine.Sorry for the inconvenience.

[VladimirMikulic]

👍

[sssash18]

@VladimirMikulic Is this not a good idea as you closed the issue .

[VladimirMikulic]

@sssash18 you said that it works fine now and I closed this.

[sssash18]

@VladimirMikulic Actually I edited the title of issue and informed you that it's fine.

[VladimirMikulic]

This is an issue, right?

[sssash18]

This is an issue, right?

Yes it is a issue @VladimirMikulic .Thanks for reopening.

[cesswairimu]

This is actually not a bug its designed like that, you have to go the profile to unban a user. Maybe we can have a discussion if we need to change that.

[sssash18]

@cesswairimu won't it be little inconvenient for the admin to go to the user's profile and then unban it?

[cesswairimu]

Having the unban button there could cause being clicked accidentally

[sssash18]

@cesswairimu to prevent that I have included a alert dialog box in my PR.

[cesswairimu]

@sssash18 still not sure about this pinging @publiclab/maintainers to get their thoughts on this

[SANJAY072000]

@cesswairimu I think instead of going to the profile we should have a list of all with a toggle button beside each list item to ban or unban profile corresponding to that list item

[jywarren]

Hi, i think one issue here is that we are aiming to have very maintainable code and so are a little hesitant to add complex interfaces in duplicate. I wonder if we could do 2 things:

1. could we format the banned label a bit? Off topic, but it looks a little funny, no?
2. could we have, on a second line in the popup, something that says Unban on profile and link to the profile? this wouldn't require a test to protect new functionality and is pretty simple. What do you think?

[ebarry]

sounds good to me to direct to the tools that already exist on profile pages

[stale]

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈.

[imajit]

@jywarren @cesswairimu i would like to work on this

[cesswairimu]

That's great @imajit 🎉... kindly check out Jeff's comment, that is what we would like to implement on this issue for now. Thanks

[cesswairimu]

Reopening this, tests remaining.