Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System Tests] Save & Recover Buttons #9139

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

noi5e
Copy link
Contributor

@noi5e noi5e commented Feb 6, 2021

Related to #9131, Refactoring Save & Recover

Oops, after all the talk about it in #9132, I realized that I FORGOT to commit the new system test for save & recover buttons.

Here it is!


(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)

@noi5e noi5e added testing issues are usually for adding unit tests, integration tests or any other tests for a feature JavaScript outreachy labels Feb 6, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 6, 2021

@codeclimate
Copy link

codeclimate bot commented Feb 6, 2021

Code Climate has analyzed commit d5daf73 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@449e6ac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9139   +/-   ##
=======================================
  Coverage        ?   82.12%           
=======================================
  Files           ?      100           
  Lines           ?     5931           
  Branches        ?        0           
=======================================
  Hits            ?     4871           
  Misses          ?     1060           
  Partials        ?        0           

@noi5e
Copy link
Contributor Author

noi5e commented Feb 6, 2021

Ready to merge!

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Thank you!

@jywarren jywarren merged commit c705479 into publiclab:main Feb 6, 2021
@noi5e noi5e deleted the save-and-recover-test branch February 7, 2021 03:15
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JavaScript outreachy readytomerge testing issues are usually for adding unit tests, integration tests or any other tests for a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants