Refactor Comment Editor Save & Recover #9132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noi5e
added
JavaScript
feature
|
|
noi5e
commented
Feb 5, 2021
noi5e
commented
Feb 5, 2021
| // for save & recover buttons | ||
| $('.save-button').on('click', function(e) { | ||
| $E.setState(e.currentTarget.dataset.formId); // string that is: "main", "reply-123", "edit-123" etc. | ||
| $E.save($E); |
There was a problem hiding this comment.
$E.setState in three new places: save buttons, recover buttons, clicking on textareas.
noi5e
commented
Feb 5, 2021
| id="text-input-edit-<%= comment.id%>" | ||
| class="form-control text-input" | ||
| name="body" | ||
| data-form-id="edit-<%= comment.id %>" |
There was a problem hiding this comment.
The editor needs this data-form-id attribute to setState.
Codecov Report
@@ Coverage Diff @@
## main #9132 +/- ##
=======================================
Coverage ? 82.12%
=======================================
Files ? 100
Lines ? 5931
Branches ? 0
=======================================
Hits ? 4871
Misses ? 1060
Partials ? 0 |
noi5e
commented
Feb 5, 2021
| > | ||
| Recover | ||
| <i class="fas fa-undo"></i> |
There was a problem hiding this comment.
New icon for the Recover Button!
Now it looks like this:
Before (bleh):
noi5e
commented
Feb 5, 2021
|
|
||
| // textAreas | ||
| $('.text-input').on('click', function(e) { | ||
| $E.setState(e.currentTarget.dataset.formId); |
There was a problem hiding this comment.
Video of setState when clicking into a comment form: https://user-images.githubusercontent.com/4361605/106988941-d9c5c580-6725-11eb-964c-6aa81728aeb7.mov
|
Code Climate has analyzed commit 0811c5e and detected 0 issues on this pull request. View more on Code Climate. |
jywarren
approved these changes
Feb 6, 2021
|
Looks super!!! |
|
Thank you!!! |
This was referenced Feb 6, 2021
manchere
pushed a commit
to manchere/plots2
that referenced
this pull request
Feb 13, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test * add text-input class, data-form-id attribute to textarea publiclab#9004 publiclab#9131 * add data-form-id to save & recover buttons publiclab#9004 publiclab#9131 * E.setState when clicking save, recover, & .text-input publiclab#9004 publiclab#9131 * refactor save & recover publiclab#9004 publiclab#9131 * add icon to recover button publiclab#9004 publiclab#9131 * restore edit button tooltip publiclab#9004 publiclab#9131 * save with window.location.pathname, not href publiclab#9004 publiclab#9131 * new system test for save & recover publiclab#9004 publiclab#9131 * update test selector publiclab#9004 publiclab#9131
lagunasmel
pushed a commit
to lagunasmel/plots2
that referenced
this pull request
Mar 2, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test * add text-input class, data-form-id attribute to textarea publiclab#9004 publiclab#9131 * add data-form-id to save & recover buttons publiclab#9004 publiclab#9131 * E.setState when clicking save, recover, & .text-input publiclab#9004 publiclab#9131 * refactor save & recover publiclab#9004 publiclab#9131 * add icon to recover button publiclab#9004 publiclab#9131 * restore edit button tooltip publiclab#9004 publiclab#9131 * save with window.location.pathname, not href publiclab#9004 publiclab#9131 * new system test for save & recover publiclab#9004 publiclab#9131 * update test selector publiclab#9004 publiclab#9131
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test * add text-input class, data-form-id attribute to textarea publiclab#9004 publiclab#9131 * add data-form-id to save & recover buttons publiclab#9004 publiclab#9131 * E.setState when clicking save, recover, & .text-input publiclab#9004 publiclab#9131 * refactor save & recover publiclab#9004 publiclab#9131 * add icon to recover button publiclab#9004 publiclab#9131 * restore edit button tooltip publiclab#9004 publiclab#9131 * save with window.location.pathname, not href publiclab#9004 publiclab#9131 * new system test for save & recover publiclab#9004 publiclab#9131 * update test selector publiclab#9004 publiclab#9131
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
* merge branches publiclab#9104 publiclab#9107 publiclab#9108 publiclab#9110 publiclab#9118 * change #dropzone-large ID to #comment-form-body * add comprehensive preview button test * add text-input class, data-form-id attribute to textarea publiclab#9004 publiclab#9131 * add data-form-id to save & recover buttons publiclab#9004 publiclab#9131 * E.setState when clicking save, recover, & .text-input publiclab#9004 publiclab#9131 * refactor save & recover publiclab#9004 publiclab#9131 * add icon to recover button publiclab#9004 publiclab#9131 * restore edit button tooltip publiclab#9004 publiclab#9131 * save with window.location.pathname, not href publiclab#9004 publiclab#9131 * new system test for save & recover publiclab#9004 publiclab#9131 * update test selector publiclab#9004 publiclab#9131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9004 (Object-Oriented Refactor) and Partial Fix for #9131 (Save & Recover Issues)
I wrote a more detailed write-up in the above issue here: #9131 (comment)
This is ready to merge.
(This issue is part of the larger Comment Editor Overhaul Project with Outreachy. Refer to Planning Issue #9069 for more context)